8000 [CAPY-1169][BpkChipGroup]: Set Chip Group Nudgers edge threshold by lucascomp · Pull Request #3816 · Skyscanner/backpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CAPY-1169][BpkChipGroup]: Set Chip Group Nudgers edge threshold #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[CAPY-1169][BpkChipGroup]: Set Chip Group Nudgers edge threshold #3816

merged 1 commit into from
May 7, 2025

Conversation

lucascomp
Copy link
Contributor
@lucascomp lucascomp commented May 2, 2025 •
edited
Loading

There is an intermittent edge case where the right hand nudger is never disabled due to 1px calculation error, which may occurs depending on a combination of parents width and screen width. Unfortunately, I was not able to find the pattern that causes the issue, but looking for some external references the suggestion is to introduce a threshold of 2 pixels before evaluating nudgers conditions.

Before After
Screen.Recording.2025-05-02.at.14.57.17.mov
Screen.Recording.2025-05-02.at.16.10.17.mov

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@lucascomp lucascomp added the patch Patch production bug label May 2, 2025
@lucascomp lucascomp requested review from Iain530 and a team May 2, 2025 14:09
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3816 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link
Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 5955c97

Iain530
Iain530 approved these changes May 2, 2025
View reviewed changes
Copy link
Member
@Iain530 Iain530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@GCpigsic GCpigsic merged commit 0eb0c9b into main May 7, 2025
11 checks passed
@GCpigsic GCpigsic deleted the CAPY-1169-chip-group-nugder-offset branch May 7, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GCpigsic GCpigsic GCpigsic approved these changes

@Iain530 Iain530 Iain530 approved these changes

Assignees
No one assigned
Labels
patch Patch production bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucascomp @GCpigsic @Iain530
0