8000 [CAPY-1378][BpkImage]: Fixing bpk-background-image loading spinner position by lucascomp · Pull Request #3819 · Skyscanner/backpack · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[CAPY-1378][BpkImage]: Fixing bpk-background-image loading spinner position #3819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

[CAPY-1378][BpkImage]: Fixing bpk-background-image loading spinner position #3819

merged 3 commits into from
May 8, 2025

Conversation

lucascomp
Copy link
Contributor
@lucascomp lucascomp commented May 7, 2025 •
edited
Loading

This PR fixes the position of the loading spinner for bpk-background-image by fixing the class names from bpk-image-* to bpk-background-image-*.

Before After
Screenshot 2025-05-07 at 13 00 17 Screenshot 2025-05-07 at 12 59 59

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@lucascomp lucascomp requested review from a team May 7, 2025 11:14
@lucascomp lucascomp added the patch Patch production bug label May 7, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3819 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3819 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link
Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against a48929c

GCpigsic
GCpigsic approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor
@GCpigsic GCpigsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@GCpigsic GCpigsic merged commit 579964a into main May 8, 2025
10 checks passed
@GCpigsic GCpigsic deleted the CAPY-1378-fixing-bg-image-spinner branch May 8, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renton4code renton4code renton4code approved these changes

@GCpigsic GCpigsic GCpigsic approved these changes

Assignees
No one assigned
Labels
patch Patch production bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucascomp @renton4code @GCpigsic
0