BUG: Skip "CI (Build)" workflow if any SuperBuild changes on "nightly-main" #7945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bc60d64 to
5765229
Compare
Simplify the logic for determining when to upload the Slicer package artifact in the "CI (Build)" workflow.
Skip the "CI (Build)" workflow if changes to "External_*.cmake" files are detected since the last Preview build. Pull request builds likely require an updated Docker image, which provides external dependencies, and building with outdated dependencies could lead to failures. To avoid this, the CI build is skipped when SuperBuild file changes may require an updated image. Additionally, since the GitHub action `dorny/paths-filter` does not suppor specifying the `base` input for pull request events, we replaced it with the `tj-actions/changed-files` action. This resolves the warning: "'base' input parameter is ignored when action is triggered by pull request event".
7c85d01 to
729b9f1
Compare
NextCheck if latest
|
|
@lassoan @jamesobutler @pieper When you have a chance, let me know if you have any questions 🙏 |
lassoan
approved these changes
Sep 20, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the "CI (Build)" workflow if changes to
External_*.cmakefiles are detected since the last Preview build. Pull request builds likely require an updated Docker image, which provides external dependencies, and building with outdated dependencies could lead to failures. To avoid this, the CI build is skipped when SuperBuild file changes may require an updated image.Additionally, since the GitHub action
dorny/paths-filterdoes not suppor specifying thebaseinput for pull request events, we replaced it with thetj-actions/changed-filesaction. This resolves the warning:Follow-up of #7942 (comment)