Define custom shapes #158

SjurdurS · 2025-01-24T21:16:47Z

This pull request adds a new Custom Shape Tool, called "Shape", to the Level Editor that allows you to quickly place predefined custom shapes into the current level.
Furthermore, this pull request also adds a new right click context menu option called "Save as shape..." which creates a new custom shape based on the current selection.

Custom shapes are saved as regular Elma levels (*.lev) on disk, and are grouped by sub-folders in the root folder for custom shapes. The root folder for custom shapes is called sle_shapes and will be created in the same directory as Elmanager.exe the first time a custom shape is saved.

The custom shape collection is just a folder structure with files, and therefore easily shareable / importable / exportable.

The following components can be added to custom shapes:

Polygons (always full polygons, if any vertex is selected on a polygon, the whole polygon is serialized).
Grass polygons
Objects (Apples, Killers, Flowers)
Pictures
Textures

The new Custom Shape Tool supports the following actions:

Right click to open the Shape Selection dialog
Anchoring using num 1-5 like Picture Tool.
Transformation
- Mirroring - Vertical, Horizontal or Both (toggle with num 6)
- Rotation - num 7 to rotate left, num 9 to rotate right, num 8 to reset rotation
- Scaling - Resize using (+ / - ) on the keyboard
- Reset anchoring and transformations: num 0
- The transformation state is remembered between shapes, so if you rotate one shape, and select a different one, the same settings apply to the new shape as well.

Images

New Shape button, and Shape Selection dialog

Shapes are grouped by folders.

Example shapes for quick testing

Here is an example collection of shapes you can use for trying it out.
Place the following sle_shapes folder in the same folder as the Elmanager.exe
sle_shapes.zip

Co-authored-by: Mika Lehtinen <Smibu@users.noreply.github.com>

I haven't removed the support for deserialization of JSON shapes to help with converting between the old JSON and the new LEV format.

…gon is selected

… to adjust if necessary

Smibu

Thanks for the updates, it's getting closer to finish line :) I added a few more comments here.

Found a bug (imo): if I place a shape, reopen form and cancel, it forgets the last selected shape. I think this used to work so maybe broke in refactoring.

Elmanager/LevelEditor/Shapes/ShapeSelection.cs

Elmanager/LevelEditor/Tools/CustomShapeTool.cs

Elmanager/Rendering/ElmaRenderer.cs

Elmanager/LevelEditor/Tools/CustomShapeTool.cs

Elmanager/LevelEditor/Shapes/SleShape.cs

Elmanager/LevelEditor/Shapes/LevelControl.cs

+
+        if (!IsHandleCreated)
+        {
+            SharedContext = sharedContext; // Set shared context before initialization


SjurdurS · 2025-03-06T19:12:28Z

Thanks for the updates, it's getting closer to finish line :) I added a few more comments here.

Found a bug (imo): if I place a shape, reopen form and cancel, it forgets the last selected shape. I think this used to work so maybe broke in refactoring.

Yeah I know, it happened after refactoring to storing the state in the _shapeSelection object. I left it for now but I can see if I can fix it. 8000

ExtraRendering shouldn't be needed because we have transient elements already and we don't have to render anything extra Co-authored-by: Mika Lehtinen <Smibu@users.noreply.github.com>

Co-authored-by: Mika Lehtinen <Smibu@users.noreply.github.com>

The handle should never be able to be created at this point anyways

This reverts commit a5146ac.

…election after closing Shape Selection From with the Cancel button

SjurdurS · 2025-03-06T20:17:25Z

Thanks for the updates, it's getting closer to finish line :) I added a few more comments here.
Found a bug (imo): if I place a shape, reopen form and cancel, it forgets the last selected shape. I think this used to work so maybe broke in refactoring.

Yeah I know, it happened after refactoring to storing the state in the _shapeSelection object. I left it for now but I can see if I can fix it.

The bug has been fixed here: 3fe32b0

…e info

…rong LGR when opening Shape Selection Form

Smibu

Thanks! This seems almost ready for merging. Can you update PR description to reflect current state? I will squash merge this, so PR title and description will be used as the commit message.

Elmanager/LevelEditor/Shapes/LevelControl.cs

Co-authored-by: Mika Lehtinen <Smibu@users.noreply.github.com>

SjurdurS · 2025-03-15T16:13:07Z

Thanks! This seems almost ready for merging. Can you update PR description to reflect current state? I will squash merge this, so PR title and description will be used as the commit message.

I've updated the pull request description (the first message in this pull request). Let me know if I should change anything :)

Smibu · 2025-03-15T16:59:03Z

Big thanks and congrats for getting this over the finish line. :)

I will create a build later today and announce in discord.

SjurdurS · 2025-03-15T22:57:27Z

Thank you for all your help! Very much appreciated the time you put in to helping me get this finished :)

SjurdurS added 2 commits January 24, 2025 21:11

Add support for creating and loading custom shapes

34f5caf

Fix crash when gallery directory doesn't exist

7945996

This comment was marked as outdated.

Sign in to view