8000 Initializer macros, and old-style declarations. by attipaci · Pull Request #73 · Smithsonian/SuperNOVAS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initializer macros, and old-style declarations. #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

Initializer macros, and old-style declarations. #73

merged 2 commits into from
Oct 15, 2024

Conversation

attipaci
Copy link
Collaborator
@attipaci attipaci commented Oct 15, 2024 •
edited
Loading

Mode code style fixes:

  • initializer macros (exposed with -Wextra)
  • 'Using' unused variables after declarations (old style).
  • Makefile without order-only dependencies (for older make).

@attipaci attipaci added the enhancement New feature or request label Oct 15, 2024
@attipaci attipaci added this to the 1.1.1 milestone Oct 15, 2024
@attipaci attipaci self-assigned this Oct 15, 2024
@codecov Codecov
Copy link
codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (eb6a98a) to head (d1e1b74).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           7        7           
  Lines        2802     2802           
  Branches      544      544           
=======================================
  Hits         2792     2792           
  Partials       10       10
Flag Coverage Δ
unittests 99.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frames.c 99.52% <ø> (ø)
src/novas.c 99.54% <100.00%> (ø)
src/refract.c 100.00% <ø> (ø)
src/super.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6a98a...d1e1b74. Read the comment docs.

@attipaci attipaci marked this pull request as ready for review October 15, 2024 17:38
@attipaci attipaci merged commit 23ac1f7 into main Oct 15, 2024
15 checks passed
@attipaci attipaci deleted the compiler-warnings-etc branch October 15, 2024 17:39
attipaci added a commit that referenced this pull request Oct 15, 2024
@attipaci
changelog update for PR #73
d05ac4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@attipaci attipaci

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
1 participant
@attipaci
0