8000 Add IAU/SOFA refraction model implementation by attipaci · Pull Request #173 · Smithsonian/SuperNOVAS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add IAU/SOFA refraction model implementation #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

attipaci
Copy link
Collaborator
@attipaci attipaci commented Apr 21, 2025
  • Add novas_wave_refraction(), which provides as RefractionModel implementation for SuperNOVAS that is based on the IAU/SOFA iauRefco() function.
  • Add novas_refract_wavelength() to allow specifying the observing wavelength for which refraction is to be calculated for when using wavelength-dependent refraction models, such as the above.
  • Added range checking to refract() function and novas_radio_refraction() model.

@attipaci attipaci added the enhancement New feature or request label Apr 21, 2025
@attipaci attipaci added this to the 1.4.0 milestone Apr 21, 2025
@attipaci attipaci self-assigned this Apr 21, 2025
Copy link
codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (4ed1052) to head (13ba21d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          22       22           
  Lines        4274     4335   +61     
  Branches      799      814   +15     
=======================================
+ Hits         4270     4331   +61     
  Partials        4        4           
Flag Coverage Δ
unittests 99.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/frames.c 99.71% <ø> (ø)
src/refract.c 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed1052...13ba21d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@attipaci attipaci force-pushed the sofa_refraction branch 7 times, most recently from 358523e to 043437b Compare April 22, 2025 15:27
@attipaci attipaci marked this pull request as ready for review April 22, 2025 15:32
@attipaci attipaci force-pushed the sofa_refraction branch 13 times, most recently from d5b6867 to 6af14e1 Compare April 23, 2025 00:20
@attipaci attipaci force-pushed the main branch 5 times, most recently from 2c82006 to f609082 Compare April 26, 2025 19:40
@attipaci attipaci force-pushed the sofa_refraction branch 3 times, most recently from 5040069 to 1d12097 Compare April 30, 2025 08:41
@attipaci attipaci force-pushed the sofa_refraction branch from 1d12097 to 86e6209 Compare May 7, 2025 08:03
@attipaci attipaci force-pushed the sofa_refraction branch from 86e6209 to 13ba21d Compare May 9, 2025 08:05
@attipaci attipaci merged commit e653ecb into main May 9, 2025
18 checks passed
@attipaci attipaci deleted the sofa_refraction branch May 9, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0