8000 Add acala by alistair-singh · Pull Request #1485 · Snowfork/snowbridge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add acala #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 9, 2025
Merged

Add acala #1485

merged 18 commits into from
Jun 9, 2025

Conversation

alistair-singh
Copy link
Contributor
@alistair-singh alistair-singh commented Jun 3, 2025 •
edited
Loading

Resolves: SNO-1502

yrong
yrong reviewed Jun 4, 2025
View reviewed changes
@yrong
Copy link
Contributor
yrong commented Jun 4, 2025

@alistair-singh I made PR#1486 to fix the formatting.

I suggest running pnpm format before committing, as it makes later reviews and conflict resolution easier.

@alistair-singh
Copy link
Contributor Author

I suggest running pnpm format before committing, as it makes later reviews and conflict resolution easier.

Where does the format settings come from, I ran fmt on this branch but i still see diffs with your branch?

@yrong
Copy link
Contributor
yrong commented Jun 5, 2025

Where does the format settings come from

It's from https://github.com/Snowfork/snowbridge/blob/main/web/packages/api/.prettierrc

yrong
yrong approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor
@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@yrong
Copy link
Contributor
yrong commented Jun 5, 2025

@alistair-singh I've opend another PR #1489 on top of this one with some minor improvements, please check if it’s good to merge.

@yrong
Copy link
Contributor
yrong commented Jun 6, 2025

@alistair-singh, I made some additional refactoring in PR#1490. Please take a look at your convenience — no pressure at all. I’m totally fine if you’d prefer to focus on the Acala work for now and review it later after this PR is merged.

@alistair-singh alistair-singh mentioned this pull request Jun 9, 2025
Draft
@alistair-singh alistair-singh merged commit 7dd864f into main Jun 9, 2025
1 check passed
@alistair-singh alistair-singh deleted the alistair/add-acala branch June 9, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrong yrong yrong approved these changes

Assignees
No one assigned
Labels
Component: Web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alistair-singh @yrong @claravanstaden
0