Fix FPs in S5994 and S6002 #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #257 added support for lookahead and possessive quantifiers inside of repetitions by excluding nodes on the same branch from being traversed. This correctly prevented from exploring nodes that would lead back to the lookahead/possessive quantifier under analysis. However, this original solution was mistakenly excluding valid nodes, that came after the lookahead/quantifier. This fix reduces the set of excluded node from a whole branch to only the part of the branch up to the lookahead/pos. quantifier itself.
|
SonarQube Quality Gate |
dorian-burihabwa-sonarsource
approved these changes
Oct 31, 2022
nils-werner-sonarsource
added a commit
to SonarSource/sonar-python
that referenced
this pull request
Nov 2, 2022
andreaguarino
pushed a commit
to SonarSource/sonar-python
that referenced
this pull request
Nov 2, 2022
* FP was removed due to SonarSource/sonar-analyzer-commons#269 * FP from extended ruling was removed as well
nils-werner-sonarsource
added a commit
to SonarSource/sonar-php
that referenced
this pull request
Nov 3, 2022
nils-werner-sonarsource
added a commit
to SonarSource/sonar-php
that referenced
this pull request
Nov 3, 2022
nils-werner-sonarsource
added a commit
to SonarSource/sonar-php
that referenced
this pull request
Dec 7, 2022
mstachniuk
pushed a commit
to SonarSource/sonar-php
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #257 added support for lookahead and possessive quantifiers inside of repetitions by excluding nodes on the same branch from being traversed. This correctly prevented from exploring nodes that would lead back to the lookahead/possessive quantifier under analysis. However, this original solution was mistakenly excluding valid nodes, that came after the lookahead/quantifier.
This fix reduces the set of excluded node from a whole branch to only the part of the branch up to the lookahead/pos. quantifier itself.