SONARPY-2080 Move ShannonEntropy to analyzer commons #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59dceab to
799f838
Compare
ghislainpiot
commented
Aug 22, 2024
Comment on lines
+41
to
+42
| .map(frequency -> -frequency * Math.log(frequency)) | ||
| .sum() / LOG_2; |
There was a problem hiding this comment.
I moved the division from the map to outside of it, it does not seem to affect numerical stability in the few tests
| } | ||
| int length = str.length(); | ||
| return str.chars() | ||
| .collect(HashMap<Integer, Integer>::new, (map, ch) -> map.merge(ch, 1, Integer::sum), HashMap::putAll) |
There was a problem hiding this comment.
could be simplifies:
return str.chars()
.boxed()
.collect(Collectors.groupingBy(Function.identity(), Collectors.counting()))
.values()
.stream()
.map(Long::doubleValue)
.mapToDouble(count -> count / length)
.map(frequency -> -frequency * Math.log(frequency))
.sum() / LOG_2;There was a problem hiding this comment.
I was reusing the previous SonarJava implementation, but if this one also works I can change it.
maksim-grebeniuk-sonarsource
approved these changes
Aug 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACOMMONS-17