8000 Add Subtitle Information to Interactive Search by Fabzien · Pull Request #7858 · Sonarr/Sonarr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Subtitle Information to Interactive Search #7858

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: v5-develop
Choose a base branch
from

Conversation

Fabzien
Copy link
@Fabzien Fabzien commented May 15, 2025

Description

Hi team,

This is my first contribution to the project, and I’d appreciate your feedback.
Motivation:

I often need to find releases that include subtitles in multiple languages. Since I’m using a private tracker with private releases, I can’t rely on external tools like Bazarr to fetch subtitles.

However, my private tracker provides subtitle information directly through Jackett. To make use of this, I’ve added support for displaying subtitle availability in the interactive search results.

Notes:

  • This is an initial implementation intended as a proposal.
  • I’d love your thoughts on whether this approach aligns with the project’s goals.
  • Could this feature be extended to other indexers or sources in the future?

Looking forward to your feedback and suggestions for improvement!

Screenshots for UI Changes

image

Releated issue

@Fabzien Fabzien changed the title Proposition add support for subtitles in interactive search Add Subtitle Information to Interactive Search May 15, 2025
Copy link
Member
@markus101 markus101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also support newznab parsing if it's already supported or later added.

This new column should also be optional, perhaps hidden by default (but I don't feel too strongly about that), this will allow users that don't care about subtitle languages to hide it and potentially other columns as well.

@@ -124,6 +124,24 @@ protected override List<Language> GetLanguages(XElement item)
return results;
}

protected override List<Language> GetSubtitles(XElement item)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same should be added to Newznab parsing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it.

@Fabzien
Copy link
Author
Fabzien commented May 18, 2025

@markus101 Regarding Newznab, I’ll take a look to see if I can add it.

I agree with you this new column should be optional. How do you think it should be handled? As far as I know, in interactive search there’s no option to add or remove columns like in "Queue" or "History" UI. Should we add an option in the interactive search UI?

@Fabzien
Copy link
Author
Fabzien commented May 19, 2025

Meanwhile, I added subtitles to the filter options. A possible temporary workaround could be to exclude subtitles from the interactive search display, but still allow users to filter by them.

@markus101
Copy link
Member

Yeah a similar option should be added to the UI. Logs is probably the easiest example of that in the new UI work (no longer using redux for that).

I don't thinking hiding them, but allowing filtering is worth the confusion. Going to convert this to draft while effort towards optional columns is made.

@markus101 markus101 marked this pull request as draft May 22, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0