-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Subtitle Information to Interactive Search #7858
8000New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5-develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also support newznab parsing if it's already supported or later added.
This new column should also be optional, perhaps hidden by default (but I don't feel too strongly about that), this will allow users that don't care about subtitle languages to hide it and potentially other columns as well.
@@ -124,6 +124,24 @@ protected override List<Language> GetLanguages(XElement item) | |||
return results; | |||
} | |||
|
|||
protected override List<Language> GetSubtitles(XElement item) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same should be added to Newznab
parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it.
@markus101 Regarding Newznab, I’ll take a look to see if I can add it. I agree with you this new column should be optional. How do you think it should be handled? As far as I know, in interactive search there’s no option to add or remove columns like in "Queue" or "History" UI. Should we add an option in the interactive search UI? |
Meanwhile, I added subtitles to the filter options. A possible temporary workaround could be to exclude subtitles from the interactive search display, but still allow users to filter by them. |
Yeah a similar option should be added to the UI. Logs is probably the easiest example of that in the new UI work (no longer using redux for that). I don't thinking hiding them, but allowing filtering is worth the confusion. Going to convert this to draft while effort towards optional columns is made. |
Description
Hi team,
This is my first contribution to the project, and I’d appreciate your feedback.
Motivation:
I often need to find releases that include subtitles in multiple languages. Since I’m using a private tracker with private releases, I can’t rely on external tools like Bazarr to fetch subtitles.
However, my private tracker provides subtitle information directly through Jackett. To make use of this, I’ve added support for displaying subtitle availability in the interactive search results.
Notes:
Looking forward to your feedback and suggestions for improvement!
Screenshots for UI Changes
Releated issue