8000 Bed-5758 feat(AGT): add /selector-preview endpoint by mistahj67 · Pull Request #1403 · SpecterOps/BloodHound · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bed-5758 feat(AGT): add /selector-preview endpoint #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

Bed-5758 feat(AGT): add /selector-preview endpoint #1403

merged 2 commits into from
Apr 29, 2025

Conversation

mistahj67
Copy link
Contributor

Description

Describe your changes in detail

  • Add POST /asset-group-tags/selector-preview
  • Plumbed limit through FetchNodesWithSeeds for early / polite kickouts

Motivation and Context

Resolves Bed-5758

Why is this change required? What problem does it solve?

How Has This Been Tested?

Added unit tests + locally

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Apr 25, 2025
@mistahj67 mistahj67 self-assigned this Apr 25, 2025
@mistahj67 mistahj67 force-pushed the BED-5758 branch 2 times, most recently from 912b927 to 826529c Compare April 26, 2025 00:39
AD7ZJ
AD7ZJ reviewed Apr 29, 2025
View reviewed changes
packages/go/openapi/src/paths/asset-isolation.preview-selectors.yaml
post:
operationId: PreviewSelectors
summary: Preview Selectors
description: Preview to members a selector with select.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check wording :)

AD7ZJ
AD7ZJ approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member
@AD7ZJ AD7ZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the small nit on docs

urangel
urangel approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@urangel urangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should have what is needed to fuel the view. Thank you sir 🫡

@mistahj67 mistahj67 merged commit d8e755a into main Apr 29, 2025
8 checks passed
@mistahj67 mistahj67 deleted the BED-5758 branch April 29, 2025 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AD7ZJ AD7ZJ AD7ZJ approved these changes

@urangel urangel urangel approved these changes

Assignees

@mistahj67 mistahj67

Labels
api A pull request containing changes affecting the API code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistahj67 @AD7ZJ @urangel @stephanieslamb
0