BED-5845 - Rework DAWGS Value Mapping #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7078c51 to
657448e
Compare
superlinkx
requested changes
Apr 29, 2025
superlinkx
reviewed
Apr 30, 2025
superlinkx
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic value mapping in DAWGS is poorly supported and was hacked together in order to support the first iteration of generic Cypher search for users.
Originally this logic was written for Neo4j with its caveats and quirks. Addition of the PostgreSQL driver introduced significant drift and technical debt in several of these paths.
The PostgreSQL driver for DAWGS currently targets upstream OID matching to utilize the object mapping cache found in the pgx library. This can be examined in the Scan(...) function of the PostgreSQL DAWGS driver type. The performance benefit of this optimization is not great enough to justify both the Neo4j and PostgreSQL driver deviating on mapping to DAWGS types. This deviation also made generic mapping of query results far more difficult.
The Result and Scanner interface have been refactored to remove the current ValueMapper idiom and value mapping between both the Neo4j and PostgreSQL driver is now unified.
Motivation and Context
Resolves BED-5845
Value mapping in DAWGS contains a complexity trap related to certain query return shapes. This is most prevalent when using the generic Cypher search functionality. This trap leads to CPU saturation.
How Has This Been Tested?
This refactor is covered by our existing tests.
Types of changes
Checklist: