Issue #1369: Convert domain properties with float values to integers #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mwstock - as I mentioned on the issue report, this has already been resolved and is set to release next week. I would still be happy to send you a swag package to show our gratitude for your efforts. If you'd be interested, please send me an email at shinck [at] specterops [dot] io! |
|
Apparently - I was moving too quickly this morning. I see the differences now - yours addresses a broader issue than ours was focused on (just |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The stringToInt function expects either a string or an int value for domain properties when ingesting SharpHound data. Any others data types are discarded. Integers from SharpHound collect are currently being inserted as float64 values and then deleted. This change will convert float values to integers to avoid deletion.
Motivation and Context
Resolves: #1369
Why is this change required? What problem does it solve?
How Has This Been Tested?
Tested locally with valid SharpHound collection data. Changes resulted in the missing properties values now being available in Neo4J.
Types of changes
Checklist: