8000 feat(tiering-define-selector): Add the create/edit selector page for … by urangel · Pull Request #1371 · SpecterOps/BloodHound · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(tiering-define-selector): Add the create/edit selector page for … #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 30, 2025
Merged

feat(tiering-define-selector): Add the create/edit selector page for … #1371

merged 8 commits into from
Apr 30, 2025

Conversation

urangel
Copy link
Contributor
@urangel urangel commented Apr 17, 2025 •
edited
Loading

…tier management

  • updates routing
  • creates a new page
  • updates state pivots to be based on routing

closes BED-5362

Description

  • Updates routes to be path based for tier management pages
  • Adds Tag and Selector Forms

Motivation and Context

Resolves BED-5632

Why is this change required? What problem does it solve?

This change enables create, update, delete actions for selectors

How Has This Been Tested?

Unit tests have been added and updated

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (optional):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

@urangel urangel force-pushed the BED-5362 branch 3 times, most recently from 4dfc16f to 2949df8 Compare April 18, 2025 16:08
@urangel urangel self-assigned this Apr 18, 2025
@urangel urangel added enhancement New feature or request user interface A pull request containing changes affecting the UI code. labels Apr 18, 2025
@urangel urangel force-pushed the BED-5362 branch 4 times, most recently from 098e265 to 6f36013 Compare April 22, 2025 22:06
@urangel urangel marked this pull request as ready for review April 22, 2025 22:09
@urangel urangel force-pushed the BED-5362 branch 2 times, most recently from 5be8499 to bdb5c92 Compare April 22, 2025 22:19
urangel added 3 commits April 25, 2025 07:51
@urangel
feat(tiering-define-selector): Add the create/edit selector page for …
072aa54 
…tier management

- updates routing
- creates a new page
- updates state pivots to be based on routing

closes BED-5362
@urangel
fix(define-selector): patch failing unit tests
cd2eabb
@urangel
wip: unit test selector form
781533e
TheNando
TheNando reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor
@TheNando TheNando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a few small notes.

elikmiller
elikmiller reviewed Apr 28, 2025
View reviewed changes
@urangel urangel requested review from elikmiller and mistahj67 April 29, 2025 17:26
@urangel
fix: pr feedback continued
7a0609f 
- update req/res types
- style updates
- disable tag form inputs
Holocraft and others added 2 commits April 30, 2025 08:15
@Holocraft @urangel
feat: BED-5761 (#1414)
a3c61c2 
* feat(tiering-define-selector): Add the create/edit selector page for tier management

- updates routing
- creates a new page
- updates state pivots to be based on routing

closes BED-5362

* fix(define-selector): patch failing unit tests

* wip: unit test selector form

* BED-5761 added create selector button

* merge conflicts

* revert change

---------

Co-authored-by: Ulises Rangel <urangel@specterops.io>
@urangel
chore: clean up axios dep
660656f
@urangel urangel merged commit 2c29ecc into main Apr 30, 2025
8 checks passed
@urangel urangel deleted the BED-5362 branch April 30, 2025 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Holocraft Holocraft Holocraft left review comments

@TheNando TheNando TheNando left review comments

@mistahj67 mistahj67 mistahj67 left review comments

@elikmiller elikmiller elikmiller approved these changes

Assignees

@urangel urangel

Labels
enhancement New feature or request user interface A pull request containing changes affecting the UI code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@urangel @elikmiller @Holocraft @TheNando @mistahj67
0