BED-5810 - Make stbernard Less Aggressive during Golang Code Generation #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to num CPU workers and eagerly skip package directories that do not contain code generation directives
superlinkx
reviewed
Apr 22, 2025
Sign up for free
to subscribe t
5F95
o this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The golang code generation step contains a goroutine amplification trap that clobbers the snot out of my local machine every time I run generation steps. This causes skips in my Doom playthrough videos which requires me to then break flow and rewind them.
Motivation and Context
Resolves BED-5810
This is just a little nicer to developer machines by limiting concurrency and consuming more IO operations. The changeset also addresses the nested goroutine amplification trap.
How Has This Been Tested?
Code generation looks good!
Types of changes
Checklist: