8000 Fixing crashes and unexpected behavior resulting from latest changes by bobjoe400 · Pull Request #49 · SpectralPack/Talisman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing crashes and unexpected behavior resulting from latest changes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 31, 2025
Merged

Fixing crashes and unexpected behavior resulting from latest changes #49

merged 12 commits into from
Mar 31, 2025

Conversation

bobjoe400
Copy link
Member
@bobjoe400 bobjoe400 commented Mar 26, 2025 •
edited
Loading

Issue

Game crash upon trying to compute BigNums with some jokers

Result

  • Added missing return value for non-BigNums to score_number_scale as this was causing blind requirements to not show up and other things to break
  • Added lovely patch for the call to G.funcs.evaluate_play to take in an argument e when it's being added as an event.
  • Added ability for arguments to be passed into concurrent call of G.funcs.evaluate_play
  • Added math.exp() override function to use bigNum calculation.
    • This was causing Cryptid.log_random to return inf at large values of x
    • Uses lenient_bignum() to allow it to return regular numbers for functions expecting it to (non-joker scaling stuff)
  • Removed commas from BalaNotation as these would somehow get stored in the games data and break Parse
    • Found the core issue of this within Parse
  • Fixed super_juice to allow for BigNum input
  • Made lenient_bignum a global function for use in Cryptid

Requirements

None

Modified Files

lovely.toml

  • Added patch for call to G.funcs.evaulate_play when added as an event

talsiman.lua

  • Added missing return value to score_number_scale
  • Added math.exp() override
  • Added arguments being passed in to the concurrent call of G.funcs.evaluate_play
  • Fixed super_juice to allow for BigNum input
  • Made lenient_bignum a global function for use in Cryptid

big-num/omeganum.lua

  • Fixed commas breaking Parse

notaions/Balatro.lua

  • Removed commas from BalaNotation

This was referenced Mar 26, 2025
Closed
Closed
Closed
@bobjoe400 bobjoe400 changed the title Fixing of errors related to bigNum compatability Fixing errors resulting from latest changes Mar 26, 2025
@bobjoe400 bobjoe400 changed the title Fixing errors resulting from latest changes Fixing crashes and unexpected behavior resulting from latest changes Mar 26, 2025
@MathIsFun0 MathIsFun0 merged commit 7426fcd into SpectralPack:experimental Mar 31, 2025
@bobjoe400
Copy link
Member Author
bobjoe400 commented Mar 31, 2025 via email •
edited
Loading

@bobjoe400 bobjoe400 deleted the big-num-compat branch April 14, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobjoe400 @MathIsFun0
0