New landing page design #119
Conversation
|
Preview the changes: https://turinglang.org/pr-previews/119 |
|
If anyone is interested, then please feel free to take on this PR! |
* very basic redesign * make buttons interactive
* add dangling code example * add code example section
* quickfix alignment * add news and clean up scss
* improve colors * better link hover color
* paste in svg * responsive svg header
using the same background colour for the team "cards" as for the non-hoverable cards on the landing page
- added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
0046a57 to
e9e14d5
Compare
|
I will definitely have time to finish this in July. Which points would you like to see addressed before this PR can be merged? |
|
Revisiting this. Is there a reason why the old PR was closed? Also, I'd personally be happy to merge if some of the placeholder content is removed. Honestly, it's not like the existing front page has any resources, so even a fairly clean slate would be a huge improvement over the current one. |
|
I'm happy to take this on some time next week — I will try to get it into a mergeable state and we can always iterate further after it's merged. |
Apologies for the confusion. I don’t have admin permissions on this repo, and the previous PR had complex merge conflicts. Since it was from Simon’s fork, and I was adding some features to the landing page, I accidentally messed up some git operations. So I took those changes and opened a new PR from a branch within this repo to make it easier to manage.
Totally agree. However, before merging, I think we should either:
|
We will create new PR for Simon's new style
…b.io into new-landing-page
|
Hi @penelopeysm, I’ve removed @simonsteiger’s styles/theme update from this PR and moved those changes to the current theme format. I also made a few updates to the theme and added some improvements to the news slider animation. The full SCSS-based theme Simon added was actually a much better approach than the current one, but it needed some updates. For now, let’s focus on completing the landing page. I’ve backed up Simon’s theme, and I’ll open a separate PR for those styles once we’re done. |
|
Everything after News section is currently a holding a placeholder texts, can you help me update that, just ping me if any UI layout changes are required |
|
#76 - let's add these in the placeholder texts! |
I think I am still of the opinion that we don't need to add more content right now. We can restrict this PR to be just a design change. I do recognise maybe we want to add that content in the future (e.g. in a follow-up PR). Thus, what I would do is quite literally comment out everything in Doing that leaves us with just the placeholder text in the "Hello, world" and "Goodbye, world", right? Let's have a think about what we want to really showcase here. It can be more than two panels too. The target audience is likely to not even be a Julia user. In my opinion, these are the most important things we can use to 'sell' people on Turing:
Just self-requesting a review to make sure that this doesn't fall off my list. |
Agree, I have commented everything from EDIT: Citation preview -- https://turinglang.org/pr-previews/119/#cite |
Continuing #105
Preview the changes: https://turinglang.org/pr-previews/119