-
Notifications
You must be signed in to change notification settings - Fork 45
docs: revamp and clarify configuration and usage documentation #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add installation instructions for the latest and stable versions using go install
- Clarify Docker usage and configuration format explanations
- Improve guidance for converting old to new configuration formats and provide an external conversion tool link
- Restructure and expand documentation for options, mcpProxy, and mcpServers configuration fields
- Add descriptions for transport types, required fields, and client-specific options in mcpServers
- Enhance usage section with startup information and specific endpoint formats for different MCP Server types
- Clean up duplicate section breaks and improve formatting for consistency
- Add installation instructions for the latest and stable versions using go install - Clarify Docker usage and configuration format explanations - Improve guidance for converting old to new configuration formats and provide an external conversion tool link - Restructure and expand documentation for options, mcpProxy, and mcpServers configuration fields - Add descriptions for transport types, required fields, and client-specific options in mcpServers - Enhance usage section with startup information and specific endpoint formats for different MCP Server types - Clean up duplicate section breaks and improve formatting for consistency Signed-off-by: appleboy <appleboy.tw@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @appleboy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a comprehensive revamp of the mcp-proxy
documentation. The primary goal is to enhance clarity and provide more detailed guidance across various sections, including installation, configuration, and usage. These changes aim to make the project more accessible and easier to understand for new and existing users.
Highlights
- Installation Instructions: Updated the
go install
instructions to clearly differentiate between installing the latest and stable versions ofmcp-proxy
. - Configuration Clarity: Enhanced explanations for Docker usage and configuration formats, including guidance on converting old configuration formats and providing a link to an external conversion tool.
- Detailed Configuration Fields: Restructured and significantly expanded the documentation for
options
,mcpProxy
, andmcpServers
configuration fields, adding descriptions fortransportType
options, required fields, and client-specific settings withinmcpServers
. - Usage Section Improvements: Improved the 'Usage' section with clearer startup information and specific endpoint formats for different MCP Server types (SSE, streamable-HTTP).
- Formatting and Consistency: Cleaned up duplicate section breaks, improved overall formatting, and ensured consistency throughout the
README.md
file.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request significantly improves the clarity and structure of the README.md
documentation. The changes enhance installation instructions, clarify Docker usage, provide better guidance for configuration formats, and restructure key sections like options
, mcpProxy
, and mcpServers
. The usage section is also enhanced with specific endpoint formats. Overall, these are valuable improvements for user understanding and experience. The review identified one area in the usage example that could be further refined for direct copy-pasting.