8000 feat: Add ProbabilisticKeyPoint3D by kunlin596 · Pull Request #171 · TRI-ML/dgp · GitHub

More Web Proxy on the site http://driver.im/

feat: Add ProbabilisticKeyPoint3D #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kunlin596 merged 1 commit into TRI-ML:master from kunlin596:kun/feat/add-probabilistic-key-point-3d

May 30, 2025

Collaborator

kunlin596 commented

No description provided.

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 3 times, most recently from 52dc7a8 to b7958ec Compare

April 9, 2025 09:40

kunlin596 commented

View reviewed changes

dgp/utils/structures/key_point_3d.py Show resolved Hide resolved

dgp/utils/structures/key_point_3d.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/structures/key_line_3d.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/structures/key_point_3d.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/structures/key_line_3d.py Show resolved Hide resolved

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 2 times, most recently from f520398 to d9920df Compare

April 10, 2025 08:57

kunlin596 marked this pull request as ready for review

April 10, 2025 08:58

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 6 times, most recently from efd5679 to 21b9d0a Compare

April 14, 2025 04:50

kunlin596 requested a review from chrisochoatri

April 14, 2025 04:51

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 6 times, most recently from d829004 to dae233e Compare

April 16, 2025 01:33

chrisochoatri reviewed

View reviewed changes

dgp/annotations/__init__.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/annotations/__init__.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/annotations/__init__.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/annotations/key_line_3d_annotation.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/annotations/key_line_3d_annotation.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/math.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/math.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/render_3d_to_2d.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/annotations/key_line_3d_annotation.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/structures/key_line_3d.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/structures/key_point_3d.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/visualization_utils.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/visualization_utils.py Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

dgp/utils/visualization_utils.py Outdated Show resolved Hide resolved

chrisochoatri reviewed

View reviewed changes

tests/utils/test_camera.py Outdated Show resolved Hide resolved

< 8000 /div>

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 4 times, most recently from 9eb2391 to 43126d4 Compare

April 17, 2025 02:25

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch 3 times, most recently from 9d131b8 to 1d1f163 Compare

May 21, 2025 05:37


          feat: add probability annotations to 3D key points and lines

c049112

kunlin596 force-pushed the kun/feat/add-probabilistic-key-point-3d branch from 1d1f163 to c049112 Compare

May 26, 2025 00:00

kunlin596 requested a review from chrisochoatri

May 26, 2025 04:31

chrisochoatri approved these changes

View reviewed changes

Collaborator

chrisochoatri left a comment

LGTM, just double check any conversion issues related to instance id being int64 vs the default value (hex string representation of a sha/checksum).

kunlin596 merged commit 93f32a7 into TRI-ML:master

3 checks passed

kunlin596 deleted the kun/feat/add-probabilistic-key-point-3d branch

May 30, 2025 01:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0