[FEATURE]: allow non-standard SOLR_HOME for containers with empty volumes #4372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Signed-off-by: morph027 <stefan.heitmueller@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Populates non-standard
SOLR_HOMEfor containers where the attached volume is empty. This came up while running the container image on AWS ECS Fargate which does not copy the contents of a DockefileVOLUMEto the mountpoint (EFS in this case) - aws/containers-roadmap#863Workaround is to set a different
SOLR_HOME(even if not advised by upstream Apache Solr) and copy the contents of the image to this location.This only affects container runtimes other than Docker (e.g. containerd) and mounts which are not bind mounts.
How to test
docker buildx build --load -t typo3solr/ext-solr:dev -f Docker/SolrServer/Dockerfile .SOLR_HOME:docker run --rm -it --tmpfs /var/lib/solr:uid=8983,gid=8983 -e SOLR_HOME=/var/lib/solr typo3solr/ext-solr:devFixes: #4371