8000 [BUGFIX] Missing parameter type in FrequentSearches::postInitializeTemplateEngine by pschriner · Pull Request #1386 · TYPO3-Solr/ext-solr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] Missing parameter type in FrequentSearches::postInitializeTemplateEngine #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2017
Merged

[BUGFIX] Missing parameter type in FrequentSearches::postInitializeTemplateEngine #1386

merged 2 commits into from
Jul 4, 2017

Conversation

pschriner
Copy link
Contributor

Missing parameter type leads to warning in PHP7

dkd-kaehm
dkd-kaehm requested changes Jul 3, 2017
View reviewed changes
Classes/Plugin/FrequentSearches/FrequentSearches.php Outdated
@@ -83,7 +83,7 @@ protected function performAction()
* @param \ApacheSolrForTypo3\Solr\Template $template
* @return \ApacheSolrForTypo3\Solr\Template
*/
protected function postInitializeTemplateEngine($template)
protected function postInitializeTemplateEngine(\ApacheSolrForTypo3\Solr\Template $template)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import FQDN in use as its done in https://github.com/TYPO3-Solr/ext-solr/blob/release-6.1.x/Classes/Plugin/PluginBase.php#L37
protected function postInitializeTemplateEngine(Template $template)

@dkd-kaehm dkd-kaehm changed the title [BUGFIX] Fix php7 warning [BUGFIX] Missing parameter type in FrequentSearches::postInitializeTemplateEngine Jul 3, 2017
@pschriner
Copy link
Contributor Author

Thanks for the quick response

@timohund timohund merged commit 9f978e8 into TYPO3-Solr:release-6.1.x Jul 4, 2017
@timohund timohund added this to the 6.1.2 - Maintenance Release milestone Jul 5, 2017
timohund added a commit that referenced this pull request Jul 20, 2017
@timohund
6.1.2 - Maintenance release
1a3867b 
Contains:

* #1386
* #1388
* #1414
* #1418
3l73 pushed a commit to 3l73/ext-solr that referenced this pull request Dec 4, 2020
@timohund @3l73
6.1.2 - Maintenance release
9e12305 
Contains:

* TYPO3-Solr#1386
* TYPO3-Solr#1388
* TYPO3-Solr#1414
* TYPO3-Solr#1418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.2 - Maintenance Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pschriner @dkd-kaehm @timohund
0