[!!!][WIP][TASK] Unify filter handling in suggest #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4549795 to
e2db383
Compare
This pr: * Moves the addtional filters that have been passed as global argument "filters" before as tx_solr[additionalFilters] * Makes sure that these filters get applied in addition to the filters that have been configured in (plugin.tx_solr.search.query.filters) to the suggestions and topResults * Allows to pass the suggest page type to the SearchFormViewHelper as "suggestPageType" Impact: If you have passed the "filters" arguments somewhere from your own code, you now need to use tx_solr[additionalFilters] now. Fixes: TYPO3-Solr#2025 Fixes: TYPO3-Solr#1885 Fixes: TYPO3-Solr#1884
e2db383 to
d085b74
Compare
|
@Mabahe do you maybe have the time to test that pr? |
|
Patch works fine! Tested as backport to release-8.0.x 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr:
Impact: If you have passed the "filters" arguments somewhere from your own code, you now need to use tx_solr[additionalFilters] now.
Fixes: #2025
Fixes: #1885
Fixes: #1884