8000 [BUGFIX] Solves PHP Warning: Undefined array key "label". by serens · Pull Request #3998 · TYPO3-Solr/ext-solr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BUGFIX] Solves PHP Warning: Undefined array key "label". #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2024
Merged

[BUGFIX] Solves PHP Warning: Undefined array key "label". #3998

merged 1 commit into from
Apr 8, 2024

Conversation

serens
Copy link
Contributor
@serens serens commented Apr 5, 2024

If the label of a sorting field only consists of a stdWrap, the key “label” is not present, only “label.”.

What this pr does

Removes possible flooded TYPO3 log messages.

How to test

Create a simple sorting field with a label using stdWrap.

plugin.tx_solr {
  search {
    sorting = 1
    sorting {
      options >
      options {
        isnew {
          label.data = LLL:EXT:extension/Resources/Private/Language/locallang.xlf:solr.sorting.isnew
          field = sort_isnew_boolS
        }
      }
    }
  }
}

Fixes: #3997

@serens
[BUGFIX] Solves PHP Warning: Undefined array key "label".
6df527b 
If the label configuration only consists of a stdWrap, the key “label” is not present, only “label.”.
dkd-kaehm
dkd-kaehm approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator
@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix.

@dkd-kaehm dkd-kaehm merged commit 6be985b into TYPO3-Solr:main Apr 8, 2024
@serens serens deleted the bugfix/PHP-Warning-Undefined-array-key-label-in-sorting-configuration branch April 9, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] PHP Warning: Undefined array key "label" if the label of a sorting field only consists of a stdWrap
2 participants
@serens @dkd-kaehm
0