Support running without database.yml #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two minor changes to configuration_spec: - replaced adapter_name with adaptername in dummy environments; underscore is not valid in URL schema - URLencoded commas in search_path
|
WHY are we even supporting 1.8 anymore? ;( |
|
Hi @dividedmind, what an awesome work! About Ruby 1.8 support, I agree we could drop it, the idea was to keep it for as long as it's not too much of a burden or require too much additional code. I wonder how much people rely on this support though... What about creating an issue and asking for feedback about dropping it? |
| end | ||
|
|
||
| # allow easier access | ||
| def method_missing(key, *a) |
There was a problem hiding this comment.
Maybe you can implement the other part of this: respond_to_missing??
|
Just an issue would be too easily overlooked; how do you like the approach in #80 ? |
Sometimes stuff (eg. search path) is set from elsewhere. But a config with no adapter nor url is unlikely to be valid. Note this is purely cosmetic change: it would fail either way, but this allows for a better error message.
JonathanTron
added a commit
that referenced
this pull request
Dec 22, 2014
Support running without database.yml
JonathanTron
added a commit
that referenced
this pull request
Dec 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for running with only DATABASE_URL for 12 factor compliance.
Also refactored the database configuration code.