Support specifying 'url' in configuration files #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this worked fine for all Sequel connections, but broke for all rake tasks since the URL wasn't parsed. This adds support to the Storage helpers, which fixes the rake tasks.
| @@ -12,10 +12,9 @@ | |||
| }, | |||
| 'test' => { | |||
| 'adapter' => 'postgres', | |||
| 'url' => 'postgres://127.0.0.1/sequel_rails_test_storage_test', | |||
There was a problem hiding this comment.
It was a bit hard for me to find a good place to add the Storage::Abstract tests - let me know where you think that'd be appropriate.
|
@JonathanTron Sorry to bug you directly, but: any feedback on this one? Would be great to see full |
|
Hi @lfittl, thanks for the PR and sorry for the delayed response. It is indeed not handled properly in the current code and you PR fix this. Thanks a lot for your work. |
JonathanTron
added a commit
that referenced
this pull request
Apr 28, 2016
|
@JonathanTron Yay, thanks for merging - happy that I don't have to keep a fork around :-) |
|
@lfittl You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this works fine for all Sequel connections, but breaks for all rake tasks since the URL isn't parsed. This ends up being a deal breaker when using
sequel-railswith aconfig/database.ymlthat looks like this:This adds support to the Storage helpers, which fixes the rake tasks.