Install plugin using kcoreaddons (fixes #36) #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsh
approved these changes
Jun 2, 2025
Tatsh
added a commit
to Tatsh/tatsh-overlay
that referenced
this pull request
Jun 2, 2025
With the change from @OndraM to use kcoreaddons, the src_install() can be removed. Signed-off-by: Andrew Udvare <audvare@gmail.com> Thanks-to: @OndraM Related: Tatsh/kate-wakatime#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
add_libraryusekcoreaddons_add_pluginfrom CoreAddons, so that the plugin is installed to the proper directory.Currently the plugin attempts to install to the root directory
/ktexteditor/ktexteditor_wakatime.so, causing it not to be used by Kate. See #36