8000 Trim spaces from elements of split XFF string by dchandekstark · Pull Request #459 · TecharoHQ/anubis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Trim spaces from elements of split XFF string #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

dchandekstark
Copy link
Contributor
@dchandekstark dchandekstark commented May 6, 2025

Fixed X-Forwarded-For parsing bug identified in #455 .

Checklist:

  • Added a description of the changes to the [Unreleased] section of docs/docs/CHANGELOG.md
  • Added test cases to the relevant parts of the codebase
  • Ran integration tests npm run test:integration (unsupported on Windows, please use WSL)

@Xe
Copy link
Contributor
Xe commented May 7, 2025

Can you add a test case for this?

Copy link
Contributor
@Xe Xe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo test coverage

@Xe Xe enabled auto-merge (squash) May 8, 2025 03:31
@Xe
Copy link
Contributor
Xe commented May 8, 2025

Thanks much!

@Xe Xe merged commit 7f0f691 into TecharoHQ:main May 8, 2025
4 checks passed
@JasonLovesDoggo
Copy link
Member
JasonLovesDoggo commented May 8, 2025

Is #455 good to close?

JasonLovesDoggo pushed a c 7688 ommit to JasonLovesDoggo/anubis that referenced this pull request Jun 17, 2025
* Trim spaces from elements of split XFF string

* Adds test to verify that spaces in original XFF header are handled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0