Added glow and fzf-thr #487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShutdownRepo
requested changes
Apr 21, 2025
Comment on lines
+213
to
+220
| colorecho "Installing glow" | ||
| wget https://github.com/charmbracelet/glow/releases/download/v2.1.0/glow_2.1.0_Linux_x86_64.tar.gz -O /tmp/glow.tar.gz | ||
| tar -xvf /tmp/glow.tar.gz | ||
| cp glow_2.1.0_Linux_x86_64/glow /opt/tools/bin | ||
| rm -f /tmp/glow.tar.gz | ||
| rm -rf /tmp/glow_2.1.0_Linux_x86_64/ | ||
| add-test-command "glow --help" | ||
| add-to-list "glow,https://github.com/charmbracelet/glow,glow is a tool to render Markdown inside the terminal." |
There was a problem hiding this comment.
wouldn't it be best to have a dynamic versioning for glow?
Comment on lines
+224
to
+228
| # CODE-CHECK-WHITELIST=add-aliases,add-history | ||
| colorecho "Installing thr" | ||
| git -C /opt/tools/ clone https://github.com/The-Hacker-Recipes/The-Hacker-Recipes.git | ||
| add-test-command "ls /opt/tools/The-Hacker-Recipes/" | ||
| add-to-list "thr,https://www.thehacker.recipes/,THR (The Hacker Recipes) is aimed at providing technical guides on various hacking topics." |
There was a problem hiding this comment.
we should probably include the "server install" in here, or an alias, that allows to actually run THR locally 🤷
Comment on lines
+7
to
+38
| alias fzf-thr='() { | ||
| file=$(find "/opt/tools/The-Hacker-Recipes/docs/src" -type f -name "*.md" | fzf) | ||
|
|
||
| if [ ! -z $DC_HOST ]; then | ||
| sed -i -e "s/\$DC_HOST/$DC_HOST/g" "$file"; | ||
| fi | ||
|
|
||
| if [ ! -z $PASSWORD ]; then | ||
| sed -i -e "s/\$PASSWORD/$PASSWORD/g" "$file"; | ||
| fi | ||
|
|
||
| if [ ! -z $USER ]; then | ||
| sed -i -e "s/\$USER/$USER/g" "$file"; | ||
| fi | ||
|
|
||
| if [ ! -z $NT_HASH ]; then | ||
| sed -i -e "s/\$NT_HASH/$NT_HASH/g" "$file"; | ||
| fi | ||
|
|
||
| if [ ! -z $DOMAIN ]; then | ||
| sed -i -e "s/\$DOMAIN/$DOMAIN/g" "$file"; | ||
| fi | ||
|
|
||
| if [ ! -z $DC_IP ]; then | ||
| sed -i -e "s/\$DC_IP/$DC_IP/g" "$file"; | ||
| fi | ||
|
|
||
| glow -t "$file" | ||
| old_path="$PWD" | ||
| cd /opt/tools/The-Hacker-Recipes/ | ||
| git restore . | ||
| cd $old_path |
There was a problem hiding this comment.
wouldn't be best to have this in a thr alias file? and to set a function rather than an alias?
There was a problem hiding this comment.
The brackets should be doubled, and for consistency with the rest of Exegol, the variables should be between quotes.
For instance:
if [[ ! -z "$DC_HOST" ]]; then
|
Btw, wrong target branch, changing it now |
|
we've got a conflict, can you check it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a little alias to browse
The Hacker Recipesinside the terminal, it also replace variable, I was inspired by this: https://x.com/_nwodtuhs/status/1905703421652685064.The alias make use of
glow(https://github.com/charmbracelet/glow) to render Markdown inside the terminal.Related issues
N / A
Point of attention
The
glowbinary size is around 6 MB.Image are not rendered and link between Markdown file don't work yet. Also some specific Vite syntax is not rendered (callouts, etc...).