8000 Warning cleanup ocelot by thiagoloureiro · Pull Request #743 · ThreeMammals/Ocelot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Warning cleanup ocelot #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2019
Merged

Warning cleanup ocelot #743

merged 2 commits into from
Jan 11, 2019

Conversation

thiagoloureiro
Copy link
Contributor

Fixes / New Feature #

Proposed Changes

  • Reducing warnings on Ocelot project

philproctor
philproctor approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor
@philproctor philproctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost sent this exact same PR a little while ago.

@margaale
Copy link
Contributor

I can approve it if you want

@philproctor
Copy link
Contributor

I'd go ahead and approve, no functional change and warning reduction is nice. The codebase can use 8000 a more thorough cleanup but that can cause conflicts in the future so we'll hold off for now.

@thiagoloureiro
Copy link
Contributor Author

@margaale added you as approver

@margaale margaale merged commit 02e5cea into ThreeMammals:develop Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philproctor philproctor philproctor approved these changes

@margaale margaale margaale approved these changes

@TomPallister TomPallister Awaiting requested review from TomPallister

@briansantura briansantura Awaiting requested review from briansantura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thiagoloureiro @margaale @philproctor
0