8000 Deprecate the Ocelot.Testing project in favor of its NuGet package by raman-m · Pull Request #2295 · ThreeMammals/Ocelot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Deprecate the Ocelot.Testing project in favor of its NuGet package #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 23, 2025
Merged

Deprecate the Ocelot.Testing project in favor of its NuGet package #2295

merged 23 commits into from
May 23, 2025

Conversation

raman-m
Copy link
Member
@raman-m raman-m commented May 22, 2025 •
edited
Loading

Synchronize Ocelot code with the Ocelot.Testing package

Ocelot.Testing package (v24.0) was released on May 15, 2025

  1. This PR deprecates the Ocelot.Testing project of Ocelot monorepository in favor of its Ocelot.Testing NuGet package.
  2. This PR is required before the first release of the Ocelot.Administration.IdentityServer4 extension package.

Proposed Changes

  • (Re)developed the Ocelot.Testing library as a common testing library focused on unit and acceptance testing. The goal is to have one universally useful library for testing all extension packages.
    FYI: The Steps class functionality was moved to the Ocelot.Testing library as an AcceptanceSteps class, but the Steps class remains a part of Ocelot's acceptance testing as the base class for all testing classes. Other important classes, such as BearerToken, ServiceHandler, and PortFinder, are now part of the Ocelot.Testing library.
  • Deprecated the Ocelot.Testing project in favor of its Ocelot.Testing NuGet package. ❗ This is the ultimate goal of this PR ❗
  • Deprecated the old Ocelot.IntegrationTests project, moving most of the integration tests to acceptance testing. None of them were unit tests.
  • FYI: Identity Server 4 Administration tests were part of the deprecated Ocelot.IntegrationTests and are now located in the Ocelot.Administration.IdentityServer4 repository. 8000 Ocelot's native Admin API tests must be redeveloped soon using the ASP.NET Identity framework.
  • Reviewed and improved all unit & acceptance tests to reuse actual helpers from the Ocelot.Testing library (v24.0).

raman-m added 23 commits April 30, 2025 21:27
@raman-m
Add common steps for acceptance testing aka AcceptanceSteps
5eece8c
@raman-m
Inherit from AcceptanceSteps
ca2add4
@raman-m
Clean up Steps
7014468
@raman-m
Fix LogLevelTests
5399426
@raman-m
Use Steps as a base class everywhere
160cb28
@raman-m
Refactor Steps slightly, moving most of the helpers to AcceptanceSteps
da697d7
@raman-m
Protected field name should not start with underscore char
b3e449f
8000
@raman-m
Move CacheManagerTests to acceptance testing
f11bb33
@raman-m
Refactor the GetRemoteIpAddress method of Placeholders feat
d3b0091
@raman-m
Move HeaderTests to acceptance testing, a Transformations feat
d70e6a1
@raman-m
Remove StartOcelot and add GivenOcelotIsRunning
18228a6
@raman-m
DRY: Rename GivenOcelotIsRunningWithServices in favor of GivenOcelotI…
143d0d1 
…sRunning
@raman-m
Run Ocelot using a separate port
14d39cc
@raman-m
Finish movement of HeaderTests to acceptance testing, but the test re…
8ba8b4f 
…quires redevelopment
@raman-m
Move ThreadSafeHeadersTests to acceptance testing, a Core feat
c319fb2
@raman-m
Move BearerToken to common testing project
528e408
@raman-m
Deprecate the integration testing project; it is now part of acceptan…
781d7da 
…ce testing
@raman-m
Sync code to Ocelot.Testing project, and move ServiceHandler to Ocelo…
29a7548 
…t.Testing
@raman-m
Move base unit testing classes to the Ocelot.Testing library to allow…
65e9a8c 
… them to be reused
@raman-m
Encapsulate ServiceHandler within Steps as an aggregated protected field
da3fc37
@raman-m
Encapsulate ServiceHandler within AcceptanceSteps as an aggregated pr…
c93154f 
…otected field
@raman-m
Remove Ocelot.Testing project and add reference to the Ocelot.Testing…
1a257f3 
… package v24
@raman-m
Deprecate the Ocelot.Testing project in favor of its NuGet package
ed03232
@raman-m raman-m 8000 added this to the Spring'25 milestone May 22, 2025
@raman-m raman-m requested review from RaynaldM and ggnaegi May 22, 2025 16:42
@raman-m raman-m self-assigned this May 22, 2025
@raman-m raman-m added Core Ocelot Core related or system upgrade (not a public feature) Spring'25 Spring 2025 release labels May 22, 2025
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.972% (+0.2%) from 85.75%
when pulling ed03232 on 24.0.1-Ocelot.Testing
into e78fe42 on develop.

@raman-m raman-m merged commit cae58d5 into develop May 23, 2025
4 checks passed
@raman-m raman-m deleted the 24.0.1-Ocelot.Testing branch May 23, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaynaldM RaynaldM Awaiting requested review from RaynaldM

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

Assignees

@raman-m raman-m

Labels
Core Ocelot Core related or system upgrade (not a public feature) Spring'25 Spring 2025 release
Projects
None yet
Milestone
Spring'25
Development

Successfully merging this pull request may close these issues.
2 participants
@raman-m @coveralls
0