#941 Added SseDelegatingHandler #2300
Conversation
|
@raman-m Please review. |
There was a problem hiding this comment.
To be fair, this is a draft version of the feature. This handler has not yet been integrated into Ocelot's pipeline. We need to ensure the feature is functional by writing acceptance tests that make real HTTP requests to an Ocelot instance.
Could you continue working on this pull request?
Rest assured, we will guide and support you throughout the development process.
|
|
||
| namespace Ocelot.Requester | ||
| { | ||
| public class SseDelegatingHandler : DelegatingHandler |
There was a problem hiding this comment.
This handler has been designed, but it hasn't been integrated into Ocelot's pipeline yet.
| public class SseDelegatingHandlerTests | ||
| { | ||
| [Fact] | ||
| public async Task SendAsync_ForNonSseRequest_CallsBaseHandler() |
There was a problem hiding this comment.
Having a single unit test is just the first step in comprehensive testing.
|
@vijay-karavadra commented on July 14, 2025
No problem! The code review has been completed! |
Sure @raman-m . |
Closes #941
Proposed Changes
SseDelegatingHandlerto handle SSE event stream requests