8000 s3: pair неверно определяет характиристику для отправки команды · Issue #10 · TionAPI/tion_python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

s3: pair неверно определяет характиристику для отправки команды #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IATkachenko opened this issue Dec 4, 2020 · 0 comments
Closed

s3: pair неверно определяет характиристику для отправки команды #10

IATkachenko opened this issue Dec 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@IATkachenko
Copy link
Collaborator
IATkachenko commented Dec 4, 2020 •
edited
Loading

Версия модуля: v1.0.2
Модель бризера: s3
Версия прошивки (если известна): 0033, 003C (значения не имеет)

Описание проблемы

Выбирается просто первая из доступных характеристик, что, в общем случае, не правильно.

Порядок действий, которые приводят к проявлению проблемы

Обнаружено при работе с Home Assisant компонетом. Изначально проблема возникала при добавлении нового бризера в Home Assistant на шаге сопряжения. В упрощенном виде воспроизводится для некоторых бризеров:

tion = S3(mac)
tion.pair()

Логи

2020-12-01 12:00:57 DEBUG (MainThread) [tion_btle.s3] Pairing
2020-12-01 12:00:57 DEBUG (MainThread) [tion_btle.s3] Connecting
2020-12-01 12:00:57 DEBUG (MainThread) [tion_btle.tion] Doing _connect. Attempt 1/3
2020-12-01 12:00:58 DEBUG (MainThread) [tion_btle.s3] Collecting characteristic
2020-12-01 12:00:58 DEBUG (MainThread) [tion_btle.s3] Got characteristic Characteristic <6e400003-b5a3-f393-e0a9-e50e24dcca9e> for pairing
2020-12-01 12:00:58 DEBUG (MainThread) [tion_btle.s3] Sending pair command 3d0501000000000000000000000000000000005a to Characteristic <6e400003-b5a3-f393-e0a9-e50e24dcca9e>
2020-12-01 12:00:58 DEBUG (MainThread) [tion_btle.s3] Disconnecting
2020-12-01 12:00:58 DEBUG (MainThread) [tion_btle.s3] Done!
@IATkachenko IATkachenko added the bug Something isn't working label Dec 4, 2020
IATkachenko added a commit that referenced this issue Dec 5, 2020
@IATkachenko
fix(S3): use common way for sending pair command
89f1ca5 
We should not use own mechanism for sending pair command.
_send_request is good enough.
Fix #10
IATkachenko added a commit that referenced this issue Dec 5, 2020
@IATkachenko
fix(S3): use common way for sending pair command
a42233a 
We should not use own mechanism for sending pair command.
_send_request is good enough.
Fix #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IATkachenko
0