-
Notifications
You must be signed in to change notification settings - Fork 31
Fix editing note (comment) line #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note input uses curses' own |
Looks like Ubuntu 20 support is removed:
https://github.com/Tlf/tlf/actions/runs/15743352324/job/44374380014?pr=474 --> handled in #475 |
So we have at least three problems:
Second and third will be fixed by the PR. For the first one how about a helping note on the input fields top line: An additional idea: Can we please position the cursor to start or end of text on entering edit mode? At the moment it is positioned at start of normal input field. |
That looks good and should do for most cases. Thanks. |
updated man page too
👍 |
Editing a note (or comment) line is not really possible as editing assumes and enforces QSO-line structure.
Already entering a note can lead to strange results.

The two ^[ symbols are the escape keys the desperate user was trying to use to close the note input window.
The first chars of the input line are covered due the longer line.
When trying to fix the note one runs into a deadlock. The only way out is to kill TLF.

The fix introduces specific field definition for comment lines. When switching between different types of lines the cursor is moved to a valid position.
Also fixed a minor issue: Ctrl-A/E was not updating
field_index
, only the cursor position.