Add a link in README.md pointing to the keyboard shortcut visualization #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this looks great! Apologies for the delay in getting to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind is that the set of key bindings of tev has really grown and sometimes it's hard to keep track for users and developers (#123, #193, #229). Therefore, I translated the list of hot keys from the help popup, as well as from
ImageViewer.cpp, to a visualizer I encountered, KeyCombiner, and mentioned it in the README (it's here for quicker reviewing). It allows viewing the hot keys as a list and see the bindings associated with each modifier (or modifier combination).Please feel free to check whether the key bindings are correct and complete.
PS:
While doing the translation, I noticed that some of the key bindings are not actually in the help window. For example, the
pageUpandpageDownkeys are mapped asupordownbut were not mentioned. We can perhaps update the help window after this PR has been merged.