Fix: Wrong get logic in Bitmap class.
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Another thing: If you use the |
Torathion
approved these changes
Mar 24, 2025
|
Thank you very much! And I deeply apologize for not thoroughly checking it. It was a last minute change to get the tests working and this update was rushed anyway. I should've tested my stuff more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, I saw that you added my fixes and enhancements to the project. I'm grateful for that. Unfortunately, while I was migrating from
bitbob2 tobitbob3, I realized that thegetfunction wasn't working correctly. While dividing the power of 2 from theBitmapstate does work for the small powers of 2, it doesn't work for large powers like2048. Luckily, you've introducedILogPow2in a previous update. Using that makes it work correctly for all powers of 2.