8000 JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.20 2.13.15->2.13.16 by raphaelsolarski · Pull Request #8209 · TouK/nussknacker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.20 2.13.15->2.13.16 #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: staging
Choose a base branch
from
Open

JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.20 2.13.15->2.13.16 #8209

wants to merge 18 commits into from

Conversation

raphaelsolarski
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 10, 2025 •
edited
Loading

created: #8269
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@github-actions github-actions bot added the docs label Jun 11, 2025
@raphaelsolarski raphaelsolarski force-pushed the jdk-17-bump branch 2 times, most recently from d27ab6f to 63dbe59 Compare June 12, 2025 14:35
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jun 12, 2025
Closed
@raphaelsolarski raphaelsolarski marked this pull request as ready for review June 13, 2025 12:33
@raphaelsolarski raphaelsolarski changed the title Jdk 17 bump Upgrade Jdk 11 -> 17 Scala: 2.12.10 -> 2.12.15 Jun 13, 2025
@raphaelsolarski raphaelsolarski changed the title Upgrade Jdk 11 -> 17 Scala: 2.12.10 -> 2.12.15 JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.15 Jun 13, 2025
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
piotrp
piotrp reviewed Jun 20, 2025
View reviewed changes
piotrp
piotrp reviewed Jun 20, 2025
View reviewed changes
@raphaelsolarski raphaelsolarski changed the title JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.15 JDK and Scala upgrade. JDK 11->17 Scala 2.12.10->2.12.20 2.13.15->2.13.16 Jun 24, 2025
@raphaelsolarski raphaelsolarski requested a review from piotrp June 24, 2025 15:16
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Closed
arkadius
arkadius reviewed Jun 24, 2025
View reviewed changes
...lite/runtime/src/main/scala/pl/touk/nussknacker/engine/lite/ScenarioInterpreterFactory.scala Outdated
@@ -316,6 +316,7 @@ object ScenarioInterpreterFactory {
passingErrors[InterpretationResult, PartResult](
results,
successful => {
// order from HashMap is accidental - for now we don't have any sensible "order number" here to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orderedGroupBy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

@piotrp piotrp piotrp approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphaelsolarski @arkadius @piotrp
0