This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Update zxing to latest #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure there is only 1 static library to deal with instead of 2. Solves an issue with the bundled rust feature.
kn: Add cmake building directory as a root of searching header
This detects if the `lineL` is actually `lineL + lineB` and splits it. This fixes #749.
This makes the API more consistent with the c++ one.
Care has been taken to keep the old names functional for a transition period. A cmake warning is emitted in this case.
This brings the cmake option and the pre-processor macro in line.
This brings the cmake option in line with the #define in Version.h
'1' == foreground == bit is set == black
This sacrifices the "long" / non standard double county IDs like "US/CA". Note that the linked sources of this data does not mention Canada either.
* reorganize building such that both reader (and new creator) APIs are always present but might fail on every call, depending on build mode * new ZXingCpp.h as single point of entry for c++ API (similar to ZXingC.h) * fix a few build issues with prior untested configurations
The standard memory views (`HEAP8`, `HEAP32`, etc) are no longer exported by default in emscripten v4.0.7: emscripten-core/emscripten#24079
WASM: add `EXPORTED_RUNTIME_METHODS` to linker flags
This is faster and easier to read than constructing temporary std::string objects from char* or std::string_view just to use operator+ on them. For this to work also with const char* and char, there have to be new Size() overloads. Unfortunately, with `char ARRAY[] = "..."` Size(ARRAY) calls the `Size(const char *)` overload, not the `Size(T const (&)[N])` overload, so `N` is lost here. This required some other cleanup.
Expose structure append metadata via C API
This was discussed in #949.
See discussion in #946.
Turned out the scaling of the squaredDistance with the square of the finder pattern size ratio was skewing the cosine calculation too much, which could lead to accepting degenerate triangles like a,b,c on a line. This could cause the alignment pattern detection to find the same points for different alignment patterns and that in turn could result in RegressionLine creations with two identical points, which caused an assert to fail (see second issue in #951).
Allow to build against the image crate version 0.25.x by relaxing the version dependency.
Done with Even Better TOML plugin of VSCode, seems to agree with #957.
Add a DecoderResult::addExtra convenience helper. Also experiment with `BarcodeExtra::...` string constants for JSON keys.
(formated) example output:
{
"FilePath": "samples/qrcode-2/qr-model-1.png",
"Text": "QR Code Model 1 ",
"HRI": "QR Code Model 1 ",
"TextECI": "]Q1\\000026QR Code Model 1 ",
"Bytes": "51 52 20 43 6F 64 65 20 4D 6F 64 65 6C 20 31 20",
"Identifier": "]Q0",
"Format": "QRCode",
"ContentType": "Text",
"Position": "8x8 58x8 58x58 8x58",
"DataMask": 5,
"Version": "2"
}
Minimal fix for issue #961
Helps with one sample in #951.
The ZXingReaderTest sometimes fails, because it implicitly depends on the ZXingWriterTest, as it needs the test.png created from this test. This fix tells cmake explicitly that the ZXingReaderTest depends on the ZXingWriterTest. This ensures that these unit tests are being executed sequentially even when using ctest with the -j flag.
Make ZXingReaderTest dependent on ZXingWriterTest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.