feat: Case attachments #1243
Open
feat: Case attachments #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
cubic found 7 issues across 26 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
daryllimyt
reviewed
Jul 3, 2025
4b53071 to
d13364c
Compare
There was a problem hiding this comment.
cubic found 3 issues across 28 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
087abe2 to
b3f93a1
Compare
1. test_validate_pdf_content: Updated to use the correct exception types (FileContentMismatchError and FileSecurityError instead of ValueError) and adjusted test expectations to match the new PDF validation behavior. 2. test_upload_delete_reupload_cycle: Fixed SQLAlchemy greenlet error by re-fetching database records instead of refreshing them, and updated expectation to match service behavior (reuses same attachment record). 3. test_upload_delete_reupload_different_case: Updated expectation for upload count - the service doesn't re-upload files that exist (even if soft-deleted). 4. test_multiple_uploads_same_content_deduplication: Updated expectation to match service behavior - returns the same attachment when uploading duplicate content to the same case.
…tion - Switch from multipart/form-data to JSON with base64 encoding to bypass AWS WAF restrictions - Add comprehensive XSS protection for file downloads with Content-Disposition headers - Block SVG files entirely due to embedded JavaScript risks - Separate preview functionality from downloads with strict content type controls - Update all tests to support new base64 upload format and security features - Add @pytest.mark.anyio decorators to async tests in test_blob_storage.py 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…S protection" This reverts commit 2c8df6a.
- Add preview parameter to download endpoint for safe image viewing - Implement force_download and override_content_type in presigned URLs - Update file size limits to more conservative values (20MB/200MB/10 files) - Add SVG validation and blocking for security - Separate preview vs download functionality for XSS protection - Add comprehensive test coverage for new security features 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Rename TRACECAT__BLOB_STORAGE_BUCKET to TRACECAT__BLOB_STORAGE_BUCKET_ATTACHMENTS - Make bucket parameter required in all storage functions - Update all storage calls to explicitly pass bucket name - Remove default bucket fallback behavior - Set default presigned URL endpoint configuration - Update tests to match new bucket configuration This change improves storage organization by using separate buckets for different types of data. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove TRACECAT__BLOB_STORAGE_PRESIGNED_URL_ENDPOINT config
- Remove TRACECAT__DISABLE_PRESIGNED_URL_IP_CHECKING config
- Remove client_ip parameter from presigned URL generation
- Simplify URL transformation to directly replace MinIO internal URL
- Update tests to work with simplified storage logic
The presigned URLs now always transform "http://minio:9000" to
"{TRACECAT__PUBLIC_APP_URL}/s3" for proper routing through the proxy.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Remove client_ip parameter from get_attachment_download_url method - Update router to stop passing client_ip from request state - Fix integration tests that were failing due to the parameter mismatch 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
0aa82ed to
476d72e
Compare
476d72e to
b486dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added support for uploading, listing, downloading, and deleting file attachments on cases, using MinIO for secure blob storage.
QA:
Screenshots