Callbacks will now receive the running job as 'self' #9

Odie · 2021-02-14T08:28:04Z

Howdy!

While playing around with luajob, I found it a little strange that the callbacks do not seem to give access to the job object itself. While this is probably fine for piping output from an external process into a buffer, it makes it somewhat awkward to store & retrieve the result of the job.

For example, in the snippet in the README that uses 'git branch' to retrieve the current branch, it eventually needs to push that result into some kind of global scope via nvim_*_set_var(). It would be a lot cleaner if the result was simply stored back onto the job object itself, like so:

local luajob = require('luajob')
local git_branch = luajob:new({
  cmd = 'git branch',
  on_stdout = function(self, err, data)
    if err then
      print('error:', err)
    elseif data then
      lines = vim.fn.split(data, '\n')
      for _, line in ipairs(lines) do
        if line:find('*') then
          self.branch = (line:gsub('\n', ''))  --> store result back onto the job object
        end
      end
    end
  end,
  on_exit = function(self, err, data)
    print('job exited, branch: ', self.branch)  --> Read back the result on_exit or anywhere else where the job object is accessible
  end
})
git_branch:start()

Anyway, this little patch injects "self" into the callbacks on_stdout, on_stderr, and on_exit.

Callbacks will now receive the running job as 'self'

ce1ca8a

Odie force-pushed the master branch from 5148e11 to ce1ca8a Compare February 14, 2021 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Callbacks will now receive the running job as 'self' #9

Callbacks will now receive the running job as 'self' #9

Uh oh!

Uh oh!

Uh oh!

Callbacks will now receive the running job as 'self' #9

Are you sure you want to change the base?

Callbacks will now receive the running job as 'self' #9

Uh oh!

Conversation

Uh oh!

Uh oh!