8000 Using vertex/edge/face tool on a brush breaks view filters · Issue #3214 · TrenchBroom/TrenchBroom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using vertex/edge/face tool on a brush breaks view filters #3214

Closed
ericwa opened this issue May 12, 2020 · 4 comments · Fixed by #3218
Closed

Using vertex/edge/face tool on a brush breaks view filters #3214

ericwa opened this issue May 12, 2020 · 4 comments · Fixed by #3218
Assignees
@ericwa
Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems
Milestone
2020.1

Comments

@ericwa
Copy link
Collaborator
ericwa commented May 12, 2020 •
edited
Loading

System Information

  • current master on Windows 10
  • RC2 reported by muk
  • also 2019.6, so it's an old bug

Expected Behavior

Using edge tool shouldn't break view filters.

Steps to Reproduce

  1. New quake map.
  2. Add a wad with liquid textures, I used ikbase
  3. Click the starting brush, apply a liquid texture (I used *slimeik1)
  4. Press "e", move an edge, press Esc, Esc, Esc to return to the default tool and deselect the brush
  5. Click View ->Uncheck "Show Liquid". The brush won't hide

The "Show Liquid" view filter does work on brushes that are just modified by shift+dragging faces, so the vertex tools are somehow connected to this bug.
@ericwa ericwa added Type:Bug Errors and problems Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. labels May 12, 2020
@neogeographica
Copy link
Contributor

Same thing e.g. with Quake 3 and a detail brush. However if I save the map, all the faces are still detail. If I quit TB and reload that saved map, the hide/show now works as expected.

@ericwa ericwa added this to the 2020.1 milestone May 13, 2020
@neogeographica
Copy link
Contributor

FWIW in the detail brush example above, when things are broken each face of the brush has a zero for m_tagMask. When things are working (either before the edge move, or after quitting and reloading) each face has an m_tagmask of 36.

@ericwa
Copy link
Collaborator Author
ericwa commented May 13, 2020

Nice. We're probably just forgetting to re-generate the automatic tags after the vertex edit, or something.
8000

@neogeographica
Copy link
Contributor
neogeographica commented May 13, 2020 •
edited
Loading

BrushFace::clone() needs a fix perhaps?

edit: Yeah that looks plausible. Traced in gdb to check.

@ericwa ericwa self-assigned this May 13, 2020
ericwa added a commit that referenced this issue May 13, 2020
@ericwa
3214: update face tags when the brush changes
d586804 
Fixes #3214

Note that Brush::doSetNewGeometry clones the BrushFaces (which doesn't clone the Taggable info per face).
@ericwa ericwa mentioned this issue May 13, 2020
Merged
ericwa added a commit that referenced this issue May 13, 2020
@ericwa
3214: update face tags when the brush changes (#3218)
ee52893 
Fixes #3214

Note that Brush::doSetNewGeometry clones the BrushFaces (which doesn't clone the Taggable info per face).
kduske pushed a commit that referenced this issue May 19, 2020
@ericwa @kduske
3214: update face tags when the brush changes (#3218)
cf27707 
Fixes #3214

Note that Brush::doSetNewGeometry clones the BrushFaces (which doesn't clone the Taggable info per face).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwa ericwa

Labels
Prio:2 Medium priority: Non crash bugs that impede the user, features that add new functionality. Type:Bug Errors and problems
Projects
None yet
Milestone
2020.1
Development

Successfully merging a pull request may close this issue.

3214: update face tags when the brush changes TrenchBroom/TrenchBroom
2 participants
@ericwa @neogeographica
0