Feature/trblock #637
Feature/trblock #637
Conversation
| import java.util.logging.Logger; | ||
|
|
||
| @Singleton | ||
| public class TRBlockManager { |
There was a problem hiding this comment.
Looks really good
But I doubt if having TRBlockManager and TRBlock would make sense since they seem to be doing closely related jobs
If the concern is executing public boolean start() only once, we could put that into initialize() directly instead.
If you prefer having multiple layers of abstraction (which is good), consider creating TRBlock as an interface and creating the TRBlockImpl class which implements the TRBlock interface. In this way, we can avoid depending directly on Javalin. Or it doesn't have to be TRBlock but some more generic name like TRBlockWebServiceProvider
|
@wysohn how about like this? |
Pretty close, but not quite Here is how I envisioned: Before) After) So the point is that in 'before' scenario, TRBlockManager, which is part of TriggerReactor, depends on TRBlock, and TRBlock depends on Javalin, and this makes our project strongly depending on the changes of Javalin Instead, we let TRBlockManager to depend on TRBlockWebService |
I understood |
|
@wysohnI'm not sure if I understood well, but is this what you meant? |
Yes exactly! As a minor point, the interface name can be If you prefer to add postfix, Ipml, then |
No description provided.