Temporally Global Variable follow tree structure #646
Conversation
|
I think make more good, but im not sure |
your proposal looks good to me though. Maybe except for creating a new map, but it's probably because I didn't understand what was the purpose of it. Anyhow, I think the use of Perhaps it's better to have different implementations for each: one for the actual global variable, and one for the temp global variable. I think the code is becoming ugly and hard to change because I tried to put temp gvar and gvar into the same implementation, which was a pretty bad idea :/ They sound quite similar, but I think they deserve to be their own class, to be honest, instead of trying to put them into one |
There was a problem hiding this comment.
Thank you! Looking really good :)
So my only concern is that it seems to use String operations, which could stack up to cause some performance issue
BUT if it's working, let's merge it first and look into the performance later. Maybe users wouldn't really complain anyway
And sorry for taking forever to review. Let me know if you would like to be the maintainer yourself by any chance
Whyrano...
Download the jar for this pull request: TriggerReactor-646.zip