Tags: TsaiJin/scylla
Tags
main: handle exceptions during startup If we don't, std::terminate() causes a core dump, even though an exception is sort-of-expected here and can be handled. Add an exception handler to fix. Fixes scylladb#1379. Message-Id: <1466595221-20358-1-git-send-email-avi@scylladb.com> (cherry picked from commit 5af22f6)
Rewriting shared sstables only after all shards loaded sstables After commit faa4581, each shard only starts splitting its shared sstables after opening all sstables. This was important because compaction needs to be aware of all sstables. However, another bug remained: If one shard finishes loading its sstables and starts the splitting compactions, and in parallel a different shard is still opening sstables - the second shard might find a half-written sstable being written by the first shard, and abort on a malformed sstable. So in this patch we start the shared sstable rewrites - on all shards - only after all shards finished loading their sstables. Doing this is easy, because main.cc already contains a list of sequential steps where each uses invoke_on_all() to make sure the step completes on all shards before continuing to the next step. Fixes scylladb#1371 Signed-off-by: Nadav Har'El <nyh@scylladb.com> Message-Id: <1466426641-3972-1-git-send-email-nyh@scylladb.com> (cherry picked from commit 3372052)
Revert "Be more conservative when deciding when to shut down due to d… …isk errors" This reverts commit a617947. The change breaks 'nodetool snapshot', for example.
Revert "Revert "main: change order between storage service and drain … …execution during exit"" This reverts commit b3ed55b. The issue is in the failing dtest, not this commit. Gleb writes: "The bug is in the test, not the patch. Test waits for repair session to end one way or the other when node is killed, but for nodetool to know if repair is completed it needs to poll for it. If node dies before nodetool managed to see repair completion it will stuck forever since jmx is alive, but does not provide answers any more. The patch changes timing, repair is completed much close to exit now, so problem appears, but it may happen even without the patch. The fix is for dtest to kill jmx as part of killing a node operation." Now that Lucas fixed the problem in scylla-ccm, revert the revert. (cherry picked from commit 0255318)
tests: Add unit tests for schema_registry (cherry picked from commit 90c3170)
database.cc: Fix compilation error with boost 1.55 Message-Id: <1461067254-526-1-git-send-email-calle@scylladb.com> (cherry picked from commit 9130b0d)
PreviousNext