-
Notifications
You must be signed in to change notification settings - Fork 11
feat: added projection property for StoryMapConfig and StoryMapChapter interfaces, then enable globe projection if it is used #4997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r interfaces, then enable globe projection if it is used
🦋 Changeset detectedLatest commit: 67a61fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…b into feat/storymap-globe-mode
…onents too much. also try to reuse the same instance
… style in storymap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request!
Description
closes #4950
projection
for StoryMapConfig and StoryMapChapter interfacespinGlobe
feature together with globe modeprojection
column to database tablesprojection
columnprojection
property in storymap editorType of Pull Request
Verify the followings
develop
branchpnpm build
pnpm lint
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
packages
folder that should be noted in one or more packages' changelogs, generate a changeset by runningpnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Refer to CONTRIBUTING.MD for more information.