8000 feat: added projection property for StoryMapConfig and StoryMapChapter interfaces, then enable globe projection if it is used by JinIgarashi · Pull Request #4997 · UNDP-Data/geohub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: added projection property for StoryMapConfig and StoryMapChapter interfaces, then enable globe projection if it is used #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2025

Conversation

JinIgarashi
Copy link
Contributor
@JinIgarashi JinIgarashi commented May 14, 2025

Thank you for submitting a pull request!

Description

closes #4950

  • add projection for StoryMapConfig and StoryMapChapter interface
  • fix spinGlobe feature together with globe mode
  • add projection column to database tables
  • fix storymap endpoint to handle projection column
  • add projection property in storymap editor

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Adding tests
  • Others ()

Verify the followings

  • Code is up-to-date with the develop branch
  • No build errors after pnpm build
  • No lint errors after pnpm lint
  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
  • Make sure all the existing features working well

Changesets

  • If your PR makes a change under packages folder that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Refer to CONTRIBUTING.MD for more information.

@JinIgarashi JinIgarashi added the enhancement New feature or request label May 14, 2025
@auto-assign auto-assign bot requested review from iferencik and Thuhaa May 14, 2025 13:35
Copy link
changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: 67a61fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@undp-data/svelte-maplibre-storymap Minor
geohub Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JinIgarashi JinIgarashi marked this pull request as draft May 14, 2025 13:41
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Components May 16, 2025 06:59 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Static Image API May 16, 2025 06:59 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Svelte UNDP Design May 16, 2025 06:59 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to Static Image API May 16, 2025 06:59 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi temporarily deployed to GeoHub UserGuide May 16, 2025 06:59 — with GitHub Actions Inactive
@JinIgarashi JinIgarashi added the bug Something isn't working label May 16, 2025
@JinIgarashi JinIgarashi marked this pull request as ready for review May 16, 2025 11:26
@JinIgarashi JinIgarashi merged commit fad5083 into develop May 16, 2025
26 checks passed
@JinIgarashi JinIgarashi deleted the feat/storymap-globe-mode branch May 16, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add globe mode for GeoHub storymap
1 participant
0