8000 MSVC Warning Level 4 Compliance · Issue #151 · USCiLab/cereal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

MSVC Warning Level 4 Compliance #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AzothAmmo opened this issue Jan 8, 2015 · 8 comments
Closed

MSVC Warning Level 4 Compliance #151

AzothAmmo opened this issue Jan 8, 2015 · 8 comments
Labels
enhancement Windows
Milestone
v 1.1.1

Comments

@AzothAmmo
Copy link
Contributor

Apparently we don't play well with W4 on MSVC (see https://groups.google.com/forum/#!topic/cerealcpp/OyytjIUp1eM).
@snoodleboot
Copy link

Thank you for bringing this here. Guess that I was missing the issues part of GitHub in my brain.

@snoodleboot
Copy link

Warning 1 warning C4512: 'cereal::OutputArchivecereal::XMLOutputArchive,0' : assignment operator could not be generated

Not sure if this is an enhancement, seems to be more of a bug. meh

@AzothAmmo AzothAmmo added this to the v1.2.0 milestone Jan 17, 2015
@snoodleboot
Copy link

Hi there

Wondering if any progress has been had in this direction.

An example of this error I was seeing below

Warning 11 warning C4512: 'cereal::NameValuePair<Function::ExponentialFunction &>' : assignment operator could not be generated t:\personalsandbox\javen\third party\cereal-1.0.0\include\cereal\details\helpers.hpp

and
Warning 2 warning C4512: 'cereal::InputArchivecereal::XMLInputArchive,0' : assignment operator could not be generated t:\personalsandbox\javen\third party\cereal-1.0.0\include\cereal\cereal.hpp

These warnings are found with Warning Level 4, Warning Level 3 they vanish.

@snoodleboot
Copy link

finished the upgrade to 1.1 today. Notice that some additional warnings are appearing at level 4 for me.

numerous of these in genericstream

Warning 70 warning C4127: conditional expression is constant T:\PersonalSandBox\jAven\Third Party\cerealSerialization\cereal\external\rapidjson\genericstream.h 81 1

level 3 warning

Warning 114 warning C4244: '=' : conversion from 'uint32_t' to 'uint8_t', possible loss of data T:\PersonalSandBox\jAven\Third Party\cerealSerialization\cereal\archives\xml.hpp 519 1

@AzothAmmo
Copy link
Contributor Author

No progress has been made other than my initial look at this. May have some time this week though. From what I remember there are a lot of warnings that are caused by RapidJSON/RapidXML which I don't really want to fix - I guess for those we'll just use pragmas to ignore them. Most of the other issues looked to be easy changes though.

@snoodleboot
Copy link

Yes Shane. Saw those. Not using json so disabled the included in json
stuff. But do see it with xml and binary. Seemed like it was easy. I have
pragmaed them at this time. Ty

On Wednesday, March 18, 2015, Shane Grant notifications@github.com wrote:

No progress has been made other than my initial look at this. May have
some time this week though. From what I remember there are a lot of
warnings that are caused by RapidJSON/RapidXML which I don't really want to
fix - I guess for those we'll just use pragmas to ignore them. Most of the
other issues looked to be easy changes though.

—
Reply to this email directly or view it on GitHub
#151 (comment).

@AzothAmmo AzothAmmo mentioned this issue Mar 19, 2015
Open
@AzothAmmo AzothAmmo mentioned this issue Mar 27, 2015
Closed
@AzothAmmo AzothAmmo modified the milestones: v 1.1.1, v1.2.0 Mar 27, 2015
AzothAmmo added a commit that referenced this issue Mar 29, 2015
@AzothAmmo
Various fixes for warning level 4 with MSVC
14bc429 
closes #178
relates #151
@AzothAmmo
Copy link
Contributor Author

Give the latest develop a try and let me know how it is, I'll be pushing this out and any other quick fixes into 1.1.1.

@AzothAmmo
Copy link
Contributor Author

Closing this - if you notice any other warnings feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Windows
Projects
None yet
Milestone
v 1.1.1
Development

No branches or pull requests
2 participants
@AzothAmmo @snoodleboot
0