8000 Add more model demand vectors & refactor validation function for industry models by MoLi7 · Pull Request #176 · USEPA/useeior · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add more model demand vectors & refactor validation function for industry models #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 19, 2021
Merged

Add more model demand vectors & refactor validation function for industry models #176

merged 8 commits into from
Nov 19, 2021

Conversation

MoLi7
Copy link
Collaborator
@MoLi7 MoLi7 commented Nov 17, 2021 •
edited
Loading

One existing model demand vector is modified (838136c). Two new demand vectors are added (0e6ab39 and 1868a09) to make validation function compatible with industry models

Validation functions compareEandLCIResult and compareOutputandLeontiefXDemand are refactored to work for industry model:

> modelname <- 'USEEIOv2.0is-GHG_nodisagg'
> model <- buildModel(modelname, configpaths = NULL)
> val_1 <- compareEandLCIResult(model, use_domestic = FALSE, tolerance = 0.05)
> val_1$N_Failure
[1] 0
>
8000
; val_1_domestic <- compareEandLCIResult(model, use_domestic = TRUE, tolerance = 0.05)
> val_1$N_Failure
[1] 0
> val_2 <- compareOutputandLeontiefXDemand(model, use_domestic = FALSE, tolerance = 0.05)
> val_1$N_Failure
[1] 0
> val_2_domestic <- compareOutputandLeontiefXDemand(model, use_domestic = TRUE, tolerance = 0.05)
> val_1$N_Failure
[1] 0

@MoLi7 MoLi7 changed the base branch from master to develop November 17, 2021 23:56
@MoLi7 MoLi7 requested a review from WesIngwersen November 17, 2021 23:59
@WesIngwersen WesIngwersen marked this pull request as ready for review November 18, 2021 00:26
@WesIngwersen
Copy link
Collaborator

Looks great

@MoLi7
Copy link
Collaborator Author
MoLi7 commented Nov 18, 2021

@WesIngwersen thanks! If you approve it, I will complete the merge.

@MoLi7
Copy link
Collaborator Author
MoLi7 commented Nov 18, 2021

@WesIngwersen demand vector year should == model IO year, right? If so, I will create a anchor for model IO year and let demand vector year use that anchor to avoid hard code.

useeior/inst/extdata/modelspecs/USEEIOv2.0is-GHG_nodisagg.yml

Line 60 in 51ab301

Year: 2012

useeior/inst/extdata/modelspecs/USEEIOv2.0is-GHG_nodisagg.yml

Line 4 in 51ab301

IOYear: 2012 # Year for IO data

@WesIngwersen
Copy link
Collaborator

I think we should leave the demand year flexible. It would be possible to use demands that represent other years with a model. We just have not done that yet.

@MoLi7
Copy link
Collaborator Author
MoLi7 commented Nov 18, 2021

I think we should leave the demand year flexible. It would be possible to use demands that represent other years with a model. We just have not done that yet.

That's a fair point. What about supply chain GHG models? USEEIOv2.0.10-GHG should have demand year of 2010, while USEEIOv2.0.16-GHG should have demand year of 2016, right? @WesIngwersen

@MoLi7 MoLi7 merged commit f4c0c4f into develop Nov 19, 2021
@MoLi7 MoLi7 mentioned this pull request Nov 30, 2021
Merged
@bl-young bl-young deleted the val_ind_model branch January 14, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WesIngwersen WesIngwersen Awaiting requested review from WesIngwersen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoLi7 @WesIngwersen
0