8000 Modify model name according to new naming rule by MoLi7 · Pull Request #196 · USEPA/useeior · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modify model name according to new naming rule #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 29, 2021
Merged

Conversation

MoLi7
Copy link
Collaborator
@MoLi7 MoLi7 commented Dec 24, 2021

Names of all built-in model are modified to adapt to the updated USEEIO Model Versioning Scheme.

@MoLi7 MoLi7 requested a review from WesIngwersen December 24, 2021 00:22
@bl-young
Copy link
Collaborator

@MoLi7 I think you will need to update the github actions is the model names change:
https://github.com/USEPA/useeior/blob/revisemodelname/.github/workflows/R-CMD-check.yaml#L69-L107

@MoLi7
Copy link
Collaborator Author
MoLi7 commented Dec 28, 2021

Did I erase a comment from you, @WesIngwersen ? I was trying to link to rule #1.

@WesIngwersen
Copy link
Collaborator

Did I erase a comment from you, @WesIngwersen ? I was trying to link to rule #1.

No I moved it to the USEEIO PR where it was supposed to go - posted it in this PR by accident

@WesIngwersen
Copy link
Collaborator

This should be ready

@WesIngwersen
Copy link
Collaborator

useeior v1 can point to this hash for the versioning scheme used
https://github.com/USEPA/USEEIO/blob/8a43f7f5f847fe1ca6dadca3c433bceb3f29981b/VersioningScheme.md

accomodating to Versioning Scheme at #8a43f7f
@MoLi7
Copy link
Collaborator Author
MoLi7 commented Dec 29, 2021

@WesIngwersen adding space between "USEEIO" and "v" in model name makes model config file name non-portable:
https://github.com/USEPA/useeior/runs/4660555200?check_suite_focus=true#step:6:49
I think it's safer to not having space in model name.

@WesIngwersen
Copy link
Collaborator

We need the space just for presentation/printing purposes. in code its fine for now if there is no space

@MoLi7 MoLi7 merged commit ad48b0c into develop Dec 29, 2021
@MoLi7 MoLi7 deleted the revisemodelname branch January 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0