8000 CMake: correct the byterange flag by jmckenna · Pull Request #3131 · Unidata/netcdf-c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CMake: correct the byterange flag #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CMake: correct the byterange flag #3131

wants to merge 1 commit into from

Conversation

jmckenna
Copy link
  • incorrect reference to NETCDF_ENABLE_BYTERANGE_SUPPORT
    • should be NETCDF_ENABLE_BYTERANGE

@CLAassistant
Copy link
CLAassistant commented May 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WardF
Copy link
Member
WardF commented May 14, 2025

Thank you very much! This will be reviewed/merged ASAP, but from my personal scan it looks great :).
8000

DennisHeimbigner
DennisHeimbigner approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator
@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@jmckenna
Copy link
Author
jmckenna commented May 15, 2025 •
edited
Loading

thanks both. This was the straight forward one, I have another (CMake) pull request coming shortly that needs both your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisHeimbigner DennisHeimbigner DennisHeimbigner approved these changes

@WardF WardF Awaiting requested review from WardF WardF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmckenna @CLAassistant @WardF @DennisHeimbigner
0