8000 Dispose snail leak by vincentvvv · Pull Request #39 · UrbanCompass/Snail-Kotlin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 2, 2021. It is now read-only.

Dispose snail leak #39

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Dispose snail leak #39

merged 3 commits into from
Jul 23, 2019

Conversation

vincentvvv
Copy link
Contributor

This PR is based on the removeSubscriber PR: #38

@codecov
Copy link
codecov bot commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #39 into removeSubscriber will decrease coverage by 6.94%.
The diff coverage is 72.41%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           removeSubscriber      #39      +/-   ##
====================================================
- Coverage             91.12%   84.18%   -6.95%     
====================================================
  Files                    10       17       +7     
  Lines                   124      177      +53     
  Branches                 13       14       +1     
====================================================
+ Hits                    113      149      +36     
- Misses                    7       23      +16     
- Partials                  4        5       +1
Impacted Files Coverage Δ
...c/main/java/com/compass/snail/disposer/Disposer.kt 100% <100%> (ø)
...tlin/src/main/java/com/compass/snail/Subscriber.kt 100% <100%> (ø) ⬆️
...snail/disposer/internal/LifecycleDisposersStore.kt 100% <100%> (ø)
...tlin/src/main/java/com/compass/snail/Observable.kt 87.35% <100%> (-1.15%) ⬇️
...ail-kotlin/src/main/java/com/compass/snail/Fail.kt 100% <100%> (ø) ⬆️
...ail/disposer/internal/LifecycleDisposersFactory.kt 100% <100%> (ø)
.../compass/snail/disposer/internal/LockedDisposer.kt 100% <100%> (ø)
...l-kotlin/src/main/java/com/compass/snail/Replay.kt 100% <100%> (ø) ⬆️
...ail-kotlin/src/main/java/com/compass/snail/Just.kt 100% <100%> (ø) ⬆️
...mpass/snail/disposer/internal/LifecycleDisposer.kt 100% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61512e...c35fa53. Read the comment docs.

russellbstephens
russellbstephens reviewed Jul 23, 2019
View reviewed changes
snail-kotlin/src/main/java/com/compass/snail/disposer/LifecycleEventDisposers.kt
@@ -0,0 +1,25 @@
// Copyright © 2019 Compass. All rights reserved.
@file:Suppress("unused")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space above?

@vincentvvv vincentvvv changed the base branch from removeSubscriber to master July 23, 2019 22:14
@russellbstephens russellbstephens merged commit 08bdf0e into master Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the disposeMethod branch July 23, 2019 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@russellbstephens russellbstephens russellbstephens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentvvv @russellbstephens
0