feat: add facilities feature #1020
Conversation
…ffice-core into facility-feature
…ct/user-office-core into facility-feature
There was a problem hiding this comment.
I have tired running it locally, but the http://localhost:3000/Facility seems not to load
There is also no error in the console.
But I have a question
Is it intended that all users have at leas one facility?
| const isAuthor = review.userID === agent?.id; | ||
| if (isAuthor) { | ||
| return true; | ||
| } | ||
|
|
||
| const currentRole = agent?.currentRole?.shortCode; |
There was a problem hiding this comment.
It appears that currentRole is not used
| @@ -494,6 +494,34 @@ export default class PostgresCallDataSource implements CallDataSource { | |||
|
|
|||
| return records.map(createCallObject); | |||
| } | |||
|
|
|||
| async getCallsByFacilityMember(user: number): Promise<Call[]> { | |||
There was a problem hiding this comment.
Can this be named userId, to be easier to differentiate from user object
|
Right now it is set up so you have to be added to a facility to have one. Im not quiet sure how a deafult facility would work, at least for us. How would you see it working? |
@TCMeldrum Would you be up for a quick catch-up call on Monday/Tuesday with me and @yoganandaness regarding this PR ? |
Yeah sure, I'm free monday afternoon and all day Tuesday |
Hi @TCMeldrum would you be able for a quick chat tomorrow 10.00-10.30 CEST ? I have added a meeting, but let me know if I need to push it. Thanks |
|
Should be fine see you then |
|
@TCMeldrum General question. Does a Facility Member need to be an Instrument Scientist as well in order to get assigned to a Facility? |
Right now there is no validation on roles in order to be assigneded to a facility. For us I don't think all the people who will be assigned to facility will be instrument scientists just most of them. |
|
@yoganandaness @jekabs-karklins Any updates sorry? |
Hi. We have passed in the information to our User Officer Carina. She will be taking this up and get back to us. We will know if we find any refined approach once she gets back to us. |
|
@yoganandaness We have a call opening on the 20th which we would like this change for. If you think that we won't be able to get this in time then I have work around I would need to add that can be removed later. |
Sure. I see the PR. Let me know once the PR is ready for review. I am extremely sorry for the inconvenience. |
Description
This PR introduces the facilities feature to the application.
Motivation and Context
This feature was added to handle the association between users, instruments and facilities. It helps to streamline the assignment of users to specific facilities and instruments, improving the management and allocation of resources within the application.
Changes
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?